search

Samsung / GearVRf

The GearVR framework(GearVRf) is an Open Source VR rendering library for application development on VR-supported Android devices.
http://www.gearvrf.org
Apache License 2.0
407 stars 217 forks source link

Fixing travis build issue #1903

Closed apjagdale closed 6 years ago

apjagdale commented 6 years ago

Automated build failed since only_daydream option tried building platformsdk_support.

liaxim commented 6 years ago

You could add a comment why the check is necessary as it may not be obvious. Or you could simply check for the OVR_PLATFORM_SDK variable instead.

apjagdale commented 6 years ago

@liaxim Added check for OVR_PLATFORM_SDK. So for travis we build framework and extensions with daydream backend. There was a check before for not building platform_sdk when build is set for only_daydream.

liaxim commented 6 years ago

I mistakenly removed that check when made the change to use backend_xxx instead of the other flags.