Samsung / GearVRf

The GearVR framework(GearVRf) is an Open Source VR rendering library for application development on VR-supported Android devices.
http://www.gearvrf.org
Apache License 2.0
407 stars 217 forks source link

Dirty flag of lights not cleared at all #1954

Closed apjagdale closed 6 years ago

apjagdale commented 6 years ago

LIGHT_REMOVED flag when set is never cleared. Causes render data to be dirty every time. Issue found by gvr-cubemap demo which clears the scene which sets LIGHT_REMOVED flag and never cleared.

GearVRf DCO signed off by: Abhijit Jagdale a.jagdale@samsung.com

apjagdale commented 6 years ago

@NolaDonato Tested with framework test. They pass. There are few failures but those are irrespective of my change.

liaxim commented 6 years ago

Should this section clear the flag too?

    if (mDirty & REBUILD_SHADERS)
    {
        return scanLights();
    }
apjagdale commented 6 years ago

@liaxim No. That flag is cleared from shadersRebuilt() in render_target.cpp