Closed apjagdale closed 6 years ago
@NolaDonato Tested with framework test. They pass. There are few failures but those are irrespective of my change.
Should this section clear the flag too?
if (mDirty & REBUILD_SHADERS)
{
return scanLights();
}
@liaxim No. That flag is cleared from shadersRebuilt() in render_target.cpp
LIGHT_REMOVED flag when set is never cleared. Causes render data to be dirty every time. Issue found by gvr-cubemap demo which clears the scene which sets LIGHT_REMOVED flag and never cleared.
GearVRf DCO signed off by: Abhijit Jagdale a.jagdale@samsung.com