Fix for issue 1956; switch to glm's matrix decompose

Samsung / GearVRf

The GearVR framework(GearVRf) is an Open Source VR rendering library for application development on VR-supported Android devices.

http://www.gearvrf.org

Apache License 2.0

407 stars 217 forks source link

Fix for issue 1956; switch to glm's matrix decompose #1969

Closed liaxim closed 6 years ago

liaxim commented 6 years ago

Fix for issue #1956

GearVRf-DCO-1.0-Signed-off-by: Mihail Marinov m.marinov@samsung.com

liaxim commented 6 years ago

Fundamentally both are doing the same. The glm's implementation is more general and better tested. The only notable thing is the need to conjugate the quaternion to deal with the row vs column vector issue @crbozz initially identified.

liaxim commented 6 years ago

Planning to merge on Wednesday