Samsung / GearVRf

The GearVR framework(GearVRf) is an Open Source VR rendering library for application development on VR-supported Android devices.
http://www.gearvrf.org
Apache License 2.0
407 stars 217 forks source link

PLY file parsing, set vertexColor shader in framework #2008

Closed mwitchwilliams closed 6 years ago

mwitchwilliams commented 6 years ago

Moved setting the vertex color shader to framework from PLY_demo. A change to Ply demo PR (https://github.com/gearvrf/GearVRf-Demos/pull/647) to accompany this change.

Tested with ply, obj, glTF and fbx files to make sure only the ply file is affected by this change.

GearVRf-DCO-1.0-Signed-off-by: Mitch Williams m1.williams@partner.samsung.com

liaxim commented 6 years ago

Should we close?

mwitchwilliams commented 6 years ago

PLY file format parsing to be supported in SXR. In addition, this was not the version that would be implemented in GearVR anyway. Instead, we will likely use https://github.com/Samsung/GearVRf/pull/2006 if this is to be supported in GearVR.