search

Samsung / GearVRf

The GearVR framework(GearVRf) is an Open Source VR rendering library for application development on VR-supported Android devices.
http://www.gearvrf.org
Apache License 2.0
408 stars 217 forks source link

Possible bug exposed by the planetarium app #644

Open liaxim opened 8 years ago

liaxim commented 8 years ago

While testing the picking I noticed some of the planets were missing textures (getting green for mercury for example). The logs are littered with this:

06-27 08:06:01.198  5347  5757 E gvrf    : Error detected in Renderer::renderRenderData; name : 4, error : Light::getVec4() : specular_intensity not found
06-27 08:06:01.198  5347  5757 E gvrf    : Error detected in Renderer::renderRenderData; name : 1, error : Light::getVec4() : specular_intensity not found
06-27 08:06:01.228  5347  5757 E gvrf    : Error detected in Renderer::renderRenderData; name : 9, error : Light::getVec4() : specular_intensity not found
rahul27 commented 8 years ago

You need to add the following line:

GVRLight mLight = new GVRLight(gvrContext); mLight.setAmbientIntensity(0.5f, 0.5f, 0.5f, 1.0f); mLight.setDiffuseIntensity(1.0f, 1.0f, 1.0f, 1.0f); mLight.setSpecularIntensity(1.0f, 1.0f, 1.0f, 1.0f);

We could set it as default for apps not using this call. @roshanch will know better.

liaxim commented 8 years ago

Sounds like a reasonable default for the compatibility GVRLight since its use in code based on an older fw code doesn't require the extra call. Btw, should GVRLight be deprecated?

roshanch commented 8 years ago

Yes, we need to add default values for the light components. About deprecation, not sure whether its a good idea. adding @NolaDonato

NolaDonato commented 8 years ago

Planetarium uses GVRLight which inherits from GVRPointLight. We need to set the default specular intensity in GVRPointLight. I can add this fix.

From: Mihail [mailto:notifications@github.com] Sent: Monday, June 27, 2016 8:22 AM To: Samsung/GearVRf GearVRf@noreply.github.com Subject: [Samsung/GearVRf] Possible bug exposed by the planetarium app (#644)

While testing the picking I noticed some of the planets were missing textures (getting green for mercury for example). The logs are littered with this:

06-27 08:06:01.198 5347 5757 E gvrf : Error detected in Renderer::renderRenderData; name : 4, error : Light::getVec4() : specular_intensity not found

06-27 08:06:01.198 5347 5757 E gvrf : Error detected in Renderer::renderRenderData; name : 1, error : Light::getVec4() : specular_intensity not found

06-27 08:06:01.228 5347 5757 E gvrf : Error detected in Renderer::renderRenderData; name : 9, error : Light::getVec4() : specular_intensity not found

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/Samsung/GearVRf/issues/644, or mute the threadhttps://github.com/notifications/unsubscribe/AQw1SwgkHnd4ATL-qvU9GOtycOyHUgaLks5qP-qbgaJpZM4I_NRt.

NolaDonato commented 8 years ago

Yes. It is really just GVRPointLight.

From: Mihail [mailto:notifications@github.com] Sent: Monday, June 27, 2016 9:13 AM To: Samsung/GearVRf GearVRf@noreply.github.com Subject: Re: [Samsung/GearVRf] Possible bug exposed by the planetarium app (#644)

Sounds like a reasonable default for the compatibility GVRLight since its use in code based on an older fw code doesn't require the extra call. Btw, should GVRLight be deprecated?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/Samsung/GearVRf/issues/644#issuecomment-228794264, or mute the threadhttps://github.com/notifications/unsubscribe/AQw1S-8gVqx20bfHPGAF3y5BfiioKQ_aks5qP_aYgaJpZM4I_NRt.