Samsung / LPVS

License Pre-Validation Service analyzes which open source components and licenses are used in every patch. It returns the list of restricted licenses and the possibility of license violation on the comment with the exact code location and the open source component information.

MIT License

24 stars 26 forks source link

Pull Request

Description

Current PR includes changes in how to get the LPVS application's current version. The proposed approach doesn't need to add any dependency. It uses only application.properties and POM files of the project. Because of changes in application start, unit tests were also modified and updated.

Type of change

Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[X] Code cleanup/refactoring
[ ] Documentation update
[ ] This change requires a documentation update
[ ] CI system update
[X] Test Coverage update

Testing

By using unit tests and application start.

Checklist:

[X] My code follows the style guidelines of this project
[X] My code meets the required code coverage for lines (90% and above)
[X] My code meets the required code coverage for branches (80% and above)
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.79%. Comparing base (a7ab252) to head (d175616).

Files	Patch %	Lines
...ain/java/com/lpvs/LicensePreValidationService.java	84.61%	2 Missing :warning:

Files

Patch %

Lines

...ain/java/com/lpvs/LicensePreValidationService.java

84.61%

2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #575 +/- ## ============================================ - Coverage 92.93% 92.79% -0.14% - Complexity 545 547 +2 ============================================ Files 48 48 Lines 1825 1818 -7 Branches 222 222 ============================================ - Hits 1696 1687 -9 - Misses 61 63 +2 Partials 68 68 ```