Samsung / LPVS

License Pre-Validation Service analyzes which open source components and licenses are used in every patch. It returns the list of restricted licenses and the possibility of license violation on the comment with the exact code location and the open source component information.

https://samsung.github.io/LPVS/

MIT License

24 stars 26 forks source link

refactor: Add queue ID to the PR diffs filepath #617

Closed o-kopysov closed 2 months ago

o-kopysov commented 2 months ago

Pull Request

Description

Current PR contains the next changes:

add queueId to the pull request entity to simplify the debug process
add queueId to the file path with pull request diffs to avoid read/write conflicts in case of multithreaded processing.

Type of change

Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[X] Code cleanup/refactoring
[ ] Documentation update
[ ] This change requires a documentation update
[ ] CI system update
[X] Test Coverage update

Testing

@tdrozdovsky Need to run a functional test to check the correctness of the LPVS operation.

Checklist:

[X] My code follows the style guidelines of this project
[X] My code meets the required code coverage for lines (90% and above)
[X] My code meets the required code coverage for branches (80% and above)
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.46%. Comparing base (4fff427) to head (18171d9).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #617 +/- ## ============================================ - Coverage 93.94% 93.46% -0.48% + Complexity 624 623 -1 ============================================ Files 52 52 Lines 2130 2127 -3 Branches 248 247 -1 ============================================ - Hits 2001 1988 -13 - Misses 56 65 +9 - Partials 73 74 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.