Samsung / LPVS

License Pre-Validation Service analyzes which open source components and licenses are used in every patch. It returns the list of restricted licenses and the possibility of license violation on the comment with the exact code location and the open source component information.
https://samsung.github.io/LPVS/
MIT License
24 stars 26 forks source link

refactor: Divide file save function into 2 parts, add UTs #641

Closed o-kopysov closed 1 month ago

o-kopysov commented 1 month ago

Pull Request

Description

The file-saving function is divided into 2 parts for better maintenance. Added unit tests to cover more branches.

Type of change

Please delete options that are not relevant.

Testing

Local run of UTs.

Checklist:

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 87.75510% with 6 lines in your changes missing coverage. Please review.

Project coverage is 93.89%. Comparing base (26d4ae7) to head (70f7be9).

Files with missing lines Patch % Lines
src/main/java/com/lpvs/util/LPVSFileUtil.java 86.66% 3 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #641 +/- ## ============================================ + Coverage 93.63% 93.89% +0.25% - Complexity 635 640 +5 ============================================ Files 52 52 Lines 2185 2195 +10 Branches 255 254 -1 ============================================ + Hits 2046 2061 +15 + Misses 62 58 -4 + Partials 77 76 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.