Samsung / ONE-vscode

Visual Studio Code Extension of ONE compiler toolchain
Apache License 2.0
48 stars 50 forks source link

[OneExplorer] Targeted refresh on Change/Delete #1710

Closed dayo09 closed 1 year ago

dayo09 commented 1 year ago

This commit refreshs only the required nodes on change and delete file.

ONE-vscode-DCO-1.0-Signed-off-by: Dayoung Lee dayoung.lee@samsung.com


For #1422 #1501

jyoungyun commented 1 year ago

I can't fully understand your code at once. Could you explain the change you made in this PR? :)

dayo09 commented 1 year ago

@jyoungyun Sure :-D

Do you remember that the explorer flickers and folds all the nodes whenever there are file changes? It's because it currently rebuilds all the nodes on file change event. Now, it's improved to build the related nodes. With this draft, you can see that it doesn't flicker anymore when you save cfg or delete some model files.

(1) On Cfg file change:

(2) On Product(circle/tvn/log, ...) delete:

It's all for change/delete. I am working on 'create' event.

jyoungyun commented 1 year ago

Does this have nothing to do with folding whenever there is a file change? Because when I tested this PR, if I build cfg and create a new product file, it still folds. I thought this change is related to the folding issue. :)

dayo09 commented 1 year ago

@jyoungyun

It's all for change/delete. I am working on 'create' event.

On creation, I am working on it! :-D