Samsung / ONE-vscode

Visual Studio Code Extension of ONE compiler toolchain
Apache License 2.0
48 stars 51 forks source link

[doc] Update HowToBuild document #1748

Closed zetwhite closed 7 months ago

zetwhite commented 7 months ago

I tried to build *.visx file following the document - https://github.com/Samsung/ONE-vscode/blob/b108dd35f3311efb182879a49143bd9ef35ed917/docs/HowToBuildFromSource.md

I met some errors related with package-version :


Finally, I succeeded to build *.visx file, just using package.json in this repo. So, How about updating the how-to-build document to use package.json? I make a PR here - https://github.com/Samsung/ONE-vscode/pull/1749

dayo09 commented 7 months ago

@zetwhite

Thanks for sharing this :-D

(just warning) npm recommends using @vscode/vsce instead of vsce, It said vsce will be deprecated.

Same here. Let's fix this.

tsc not found error. It looks like tsc(I guess a typescript compiler) should be installed.

I haven't seen this error. We have typescript in our devDependency, which includes tsc. Or, did you run tsc -p ./ manually by any means?

zetwhite commented 7 months ago

@dayo09

Sorry for the confusion. The error I listed was caused by my mistake.

I didn't read the guide carefully. :cry: I didn't find the sentence npm install in ## STPE3. https://github.com/Samsung/ONE-vscode/blob/b108dd35f3311efb182879a49143bd9ef35ed917/docs/HowToBuildFromSource.md?plain=1#L25

zetwhite commented 7 months ago

Anyway, I'll update the PR to fix warning

(just warning) npm recommends using @vscode/vsce instead of vsce, It said vsce will be deprecated.