[workflows] Replace deprecated command with environment file

Samsung / ONE-vscode

Visual Studio Code Extension of ONE compiler toolchain

Apache License 2.0

48 stars 51 forks source link

Closed jongwooo closed 6 months ago

jongwooo commented 6 months ago

ONE-vscode-DCO-1.0-Signed-off-by: Jongwoo Han jongwooo.han@gmail.com

Update .github/workflows/check-daily-license.yml to use environment file instead of deprecated set-output command. For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

AS-IS

echo "::set-output name=commit_id::${COMMIT_ID}"

TO-BE

echo "commit_id=${COMMIT_ID}" >> $GITHUB_OUTPUT

jyoungyun commented 6 months ago

Looks good this PR. However, could you fork this repository and make a pr again?

jongwooo commented 6 months ago

However, could you fork this repository and make a pr again?

@jyoungyun I have currently forked this repository and created a PR, may I ask why you suggested creating a PR again?

jyoungyun commented 6 months ago

I have currently forked this repository and created a PR, may I ask why you suggested creating a PR again?

I asked to make another PR because PR check was not executed. Now I approved the PR checks and it worked well. Thank you for your contribution.