Samsung / ONE-vscode

Visual Studio Code Extension of ONE compiler toolchain
Apache License 2.0
48 stars 50 forks source link

Hide unnecessary commands in command palette #839

Closed yunjayh closed 2 years ago

yunjayh commented 2 years ago

WHAT

Let's hide unnecessary commands from command palette if it's accessible with some other buttons. features or internal functions.

WHY

There are too many commands has been shown if user enter ONE: to command palette.

image

We are scheduling to do user study after the release, which is scheduled 30 June. It can be too bothering for the users who frequently use command palette while their development.


Here is the way to hide them.

Here is official guideline :)

yunjayh commented 2 years ago

Here are lists of commands that could be found when I entered > ONE: to command palette. (based on commit 64cbe76) I categorized them in my own view. If there is any misunderstood, please let me know or feel free to fix it.

Please put ⭕ or ❌ to the table.

Partition Editor

command hide or not done
circle graph view ⭕ (hidden) :heavy_check_mark:

Circle tracer

command hide or not done
circle tracer - :heavy_check_mark:

One Explorer view

command command id hide or not done
Collapse Folders in ONE Explorer collapseAll :heavy_check_mark:
Focus on ONE Explorer View - ❌ (default command created by vscode. It seems vscode provides users 'focus on' command for every view)
Refresh (one.explorer.refresh) refresh :heavy_check_mark:
Create new ONE configuration createCfg :heavy_check_mark:
Open Containing Folder openContainingFolder :heavy_check_mark:
Rename rename :heavy_check_mark:
Open with Text Editor openAsText ⭕ (p.s. ERROR, not work on command palette, currently) :heavy_check_mark:
Run runCfg ⭕ (p.s. ERROR, not work on command palette, currently) :heavy_check_mark:

toolchain & toolchain view

command hide or not done
Foucs on Toolchain View :x: (same reason with focus on one explorer view)
Install
uninstall ⭕ (need to fix) :heavy_check_mark:
runCfg ⭕ (already hided)
Refresh (one.toolchain.refresh) ❌ (-> name will be changed to UpdateVersion or UpdateVersionList)

device view

command hide or not done
Focus on Target Devices View :x: (same reason with focus on one explorer view)
Register ⭕(this will be added if remote Device connection renewed) :heavy_check_mark:

cfg editor

command hide or not done
Open cfg in GUI ⭕ (not need to show in command palette) :heavy_check_mark:
Open cfg in GUI (legacy) ⭕ (not need to show in command palette) :heavy_check_mark:
Open cfg in Text Editor ⭕ (not need to show in command palette) :heavy_check_mark:
Open with Text Editor ⭕ (not need to show in command palette) :heavy_check_mark:

compile

command hide or not done
Run :o: :heavy_check_mark:

inference

command hide or not done
Infer :o: It was temporal function and should be deprecated :heavy_check_mark:

legacy codes

command hide or not done
build :o: :heavy_check_mark:
cfg import ⭕ (will be deprecated after some notice) :heavy_check_mark:
json tracer ⭕ (will be deprecated after some notice) :heavy_check_mark:
Toggle codelens for cfg ⭕ (will be deprecated after some notice) :heavy_check_mark:
jyoungyun commented 2 years ago

@yunjayh In my vscode, I couldn't see the ONE: Foucs on Toolchain View command. How did you make it show?

yunjayh commented 2 years ago

I didn't do anything, but I get into build mode and checked command palette with > ONE: typed. (the code was https://github.com/Samsung/ONE-vscode/commit/64cbe763db9e4d32294bc100baf81401695ee8b8 in main branch) I'll check once more!

yunjayh commented 2 years ago

@jyoungyun From both build mode and vscix package, I could fuind ONE: Focus on Toolchain View. 😮

seanshpark commented 2 years ago

FYI: separated Circle tracer from Partition Editor

dayo09 commented 2 years ago

@yunjayh I don't think ONE: uninstall belongs to ONE Explorer. Maybe ONE Toolchain? Plus, Run doesn't belong to toolchain but explorer. Seemingly, you must have had hard time matching those commands by its name on command palette. cheers.

dayo09 commented 2 years ago

@yunjayh In my vscode, I couldn't see the ONE: Foucs on Toolchain View command. How did you make it show?

@jyoungyun It seems vscode create it by default. ONE Explore view and device view also have one. Let's just let them leave.

yunjayh commented 2 years ago

With #866, following commands are remained in command palette.

image

IMHO build was introduced to run one-build with cfg which is introduced from cfg import command. Since cfg import has been hide, it seems good to hide build too.

yunjayh commented 2 years ago

Every commands which are checked to hide is removed from command palette. Thank you for every contributors!! :tada: