search

Samsung / ONE

On-device Neural Engine
Other
428 stars 152 forks source link

Fix critical coverity defects for tizen 7.5 M1 release #10730

Open chunseoklee opened 1 year ago

chunseoklee commented 1 year ago

Here is a list of critical defects :

nnfw-1.22.1/externals/TENSORFLOW-2.8.0/tensorflow/lite/delegates/gpu/cl/tensor.h http://10.113.139.115:8081/query/defects.htm?projectId=11006&cid=1599330

nnfw-1.22.1/externals/TENSORFLOW-2.8.0/tensorflow/lite/delegates/gpu/cl/tensor.cc http://10.113.139.115:8081/query/defects.htm?projectId=11006&cid=1599340

nnfw-1.22.1/externals/TENSORFLOW-2.8.0/tensorflow/lite/delegates/gpu/cl/inference_context.cc http://10.113.139.115:8081/query/defects.htm?projectId=11006&cid=1599349

nnfw-1.22.1/externals/TENSORFLOW-2.8.0/tensorflow/lite/delegates/gpu/cl/kernels/converter.cc http://10.113.139.115:8081/query/defects.htm?projectId=11006&cid=1618701

nnfw-1.22.1/externals/TENSORFLOW-2.8.0/tensorflow/lite/delegates/gpu/cl/kernels/converter.cc http://10.113.139.115:8081/query/defects.htm?projectId=11006&cid=1618705

nnfw-1.22.1/externals/TENSORFLOW-2.8.0/tensorflow/lite/delegates/gpu/common/flops_util.cc http://10.113.139.115:8081/query/defects.htm?projectId=11006&cid=1599354

nnfw-1.22.1/externals/TENSORFLOW-2.8.0/tensorflow/lite/delegates/gpu/common/selectors/operation_selector.cc http://10.113.139.115:8081/query/defects.htm?projectId=11006&cid=1599366

nnfw-1.22.1/externals/TENSORFLOW-2.8.0/tensorflow/lite/delegates/gpu/common/selectors/operation_selector.cc http://10.113.139.115:8081/query/defects.htm?projectId=11006&cid=1599373

nnfw-1.22.1/externals/TENSORFLOW-2.8.0/tensorflow/lite/delegates/gpu/common/tasks/convolution_transposed_3x3.h http://10.113.139.115:8081/query/defects.htm?projectId=11006&cid=1260382

nnfw-1.22.1/externals/TENSORFLOW-2.8.0/tensorflow/lite/delegates/gpu/common/tasks/convolution_transposed_4x4.h http://10.113.139.115:8081/query/defects.htm?projectId=11006&cid=1260385

nnfw-1.22.1/runtime/onert/backend/trix/DevContext.cc http://10.113.139.115:8081/query/defects.htm?projectId=11006&cid=1681210

I do not understand how ahub test passed in ONE 1.22.1 relelase.

chunseoklee commented 1 year ago

@hseok-oh I will try it. But cannot connect to server. PTAL

chunseoklee commented 1 year ago

I do not understand how ahub test passed in ONE 1.22.1 relelase.

I found that we are using tizen 7.0 for cov analysis. We need to create new cov analyzer(tizen7.5) in ahub system : https://github.sec.samsung.net/RS-SA/analysishub-service-webapi/issues/3498

hseok-oh commented 1 year ago

I found that we are using tizen 7.0 for cov analysis

We are using tizen 7.5. Please check analysishub-service-webapi repo issue 3386.

chunseoklee commented 1 year ago

After SBS(https://quickbuild.tizen.org/build/216933) is done, coverity analysis on ahub will be triggered. Let us wait for this.

updated : https://analysishub.sec.samsung.net/service/analyses/2039532

updated2: http://10.113.139.115:8081/query/defects.htm?projectId=10180&cid=1557057 we still have 1 critical defect

update3: I trigger again on https://analysishub.sec.samsung.net/service/analyses/2040030 (but it is not from SBS, so IDK this result is correct or not)

update4: fail with 3 major defects

chunseoklee commented 1 year ago

Now, I am able to access coverity maanger.

update4: fail with 3 major defects

done.

New SBS is triggered for checking : https://quickbuild.tizen.org/build/217366

Additional cov analysis trigged in https://analysishub.sec.samsung.net/service/analyses/2040830

lemmaa commented 1 year ago

@chunseoklee , do we need to keep this open?

glistening commented 1 year ago

For this defect,

nnfw-1.22.1/runtime/onert/backend/trix/DevContext.cc http://10.113.139.115:8081/query/defects.htm?projectId=11006&cid=1681210

10732 was prepared. But as I heard, @hseok-oh resolved in different way internally.