search

Samsung / ONE

On-device Neural Engine
Other
428 stars 157 forks source link

[onert] Add test for MinMax{Recorder,Dumper} #10808

Open glistening opened 1 year ago

glistening commented 1 year ago

Currently, test for MinMax{Recorder,Dumper} is missing. We need to add tests.

glistening commented 1 year ago

It cannot be done by writing c++ program as we usually do when we introduce new operator. Because it requires to set MINMAX_FILEPATH and read the content of generated *.h5.

It can be easily done by using existing tools onert_run and h5dump like https://github.com/Samsung/ONE/pull/10642#issuecomment-1507982532.

@hseok-oh or @chunseoklee Could you give your idea or opinion? Is it okay to write a script to run the command like above? Or should we write some test program in c++?