Closed hseok-oh closed 11 months ago
remove or disable build.
+1 to disable build
@lemmaa , your opinion ?
I'll work on this task :) With excluding unused projects while normal build, CI build.
compiler/something
) when there exist exclude.me
file in that folder-DBUILD_WHITELIST=...
is given, ignore this feature and build all modules in the list-DENABLE_EXCLUDE_ME=OFF
is given, ignore this feature and build all modules@lemmaa , any comments?
@lemmaa PTAL
Let's list unused compiler frontend projects to remove or disable build.
@hseok-oh , what's the purpose of this work?
My guess is that there are many possible reasons for this, such as
In any case, the reason, purpose, etc. must be clear so that there is no confusion in the discussion and conclusion.
And, what do you think are excluded? :)
11848 Draft implementation:
- exclude module (
compiler/something
) when there existexclude.me
file in that folder- if
-DBUILD_WHITELIST=...
is given, ignore this feature and build all modules in the list- if
-DENABLE_EXCLUDE_ME=OFF
is given, ignore this feature and build all modules- excluded module may fail in build in the future but we won't know that
- we can re-enable excluded module when ever needed again
- any build failure should be fixed at that time
@lemmaa , any comments?
@seanshpark , I agree with your draft design. However, it would be nice to check what @hseok-oh's original intention was and organize the details.
Let's list unused compiler frontend projects to remove or disable build.
@hseok-oh , what's the purpose of this work?
My guess is that there are many possible reasons for this, such as
* Optimizing CI build resources, * Reducing the difficulty of source code maintenance, * Etc.
In any case, the reason, purpose, etc. must be clear so that there is no confusion in the discussion and conclusion.
And, what do you think are excluded? :)
Reason to remove: maybe not used any more
Reason to disable build: reduce CI build resource
coco
and related, ann-api
and related, etc...Reason to disable build: reduce CI build resource
- ex)
coco
and related,ann-api
and related, etc...
In this case, isn't it necessary to automatically and regularly check the following cases among the target modules?
- excluded module may fail in build in the future but we won't know that
we can re-enable excluded module when ever needed again
- any build failure should be fixed at that time
For example, even if in frequent PR check build
or commit check build
are excluded, it is checked regularly on a daily or weekly basis and an issue is registered when a build break or test failure occurs.
- if
-DBUILD_WHITELIST=...
is given, ignore this feature and build all modules in the list
I think this option would be appropriate for such support.
Taking this into consideration, it would be a good idea to categorize and organize the target list according to the original purpose of the issue.
I think this option would be appropriate for such support.
Yup, -DENABLE_EXCLUDE_ME=OFF
is for regular checkup to build all modules :)
I'll begin posting related changes.
These are the candidate modules that "are"/"will be" excluded. Tool level modules are treated first and then related libraries that follows. Agreement or objection can be discussed in each PR for that module.
Tools
Libraries
ping @jinevening , @mhs4670go
tfinfo
is used in tf2nnpkg
v4tf
has only README.md which can be ignored
done for now. @hseok-oh , ok to close?
Let's list unused compiler frontend projects to remove or disable build.