search

Samsung / ONE

On-device Neural Engine
Other
427 stars 151 forks source link

[one-optimize] Fuse mul with FC layer #13515

Closed jinevening closed 1 week ago

jinevening commented 1 month ago

What

Let's fuse mul with preceding FC.

image

Whay

The pattern appears in fairseq decoder.

jiwaszki commented 1 month ago

Hi @jinevening , does "good first issue" label mean that the task is free to pick up? If yes, could you assign it to me? I will start working on it right away.

jinevening commented 1 month ago

does "good first issue" label mean that the task is free to pick up?

It means that the task is not too difficult (change is often limited to a single module) to start contribution to this project. You can pick a task from any open issue with no assignee. Sometimes issue owners forget to put assignees, so it would be better to leave a comment like you did in this issue.

I've assigned you to this issue. Thanks for contribution :)

Please read https://github.com/Samsung/ONE/wiki/ONE-Developer%27s-Certificate-of-Origin and https://github.com/Samsung/ONE/wiki/How-We-Work#pull-request before you post a PR.

jiwaszki commented 2 weeks ago

@seanshpark as [luci/pass] is now merged, could you take a look at the rest of opened PRs? Thanks in advance!

seanshpark commented 2 weeks ago

could you take a look at the rest of opened PRs? Thanks in advance!

Please fix the CI failures. You may have to rebase and push again.

jiwaszki commented 2 weeks ago

@seanshpark PRs are now fixed: https://github.com/Samsung/ONE/pull/13609 and https://github.com/Samsung/ONE/pull/13608

jiwaszki commented 2 weeks ago

@seanshpark https://github.com/Samsung/ONE/pull/13609 , https://github.com/Samsung/ONE/pull/13611 and https://github.com/Samsung/ONE/pull/13612 are green now

jinevening commented 1 week ago

It seems that all PRs are merged. Thanks! @jiwaszki