Samsung / ONE

On-device Neural Engine
Other
440 stars 157 forks source link

[circle-quantizer] Separate quantization functionalities from circle2circle #2617

Closed jinevening closed 4 years ago

jinevening commented 4 years ago

Currently, quantization is supported by circle2circle, which not only performs quantization but also various optimizations. To keep the tool smaller and simpler, it would be better to make a separate tool for quantization.

For this, following things must be done.

seanshpark commented 4 years ago

It's OK if you go 3 and then 1

jinevening commented 4 years ago

@seanshpark I think 1-2-3 is the way to do this task with the least number of steps. 3 must be done after 2 (otherwise, the circle-quantizer will not pass luci::validate). And it is better to do 2 after 1 (2 may affect the current circle2circle).

seanshpark commented 4 years ago

Have to thought of the name for this? circlequantizer ?

jinevening commented 4 years ago

Have to thought of the name for this? circlequantizer ?

I've thought about that, but circle-quantizer seems easier to read. Is there a reason not to use -?

seanshpark commented 4 years ago

Is there a reason not to use -?

Nope, circle-quantizer is OK. Personally I'm not used to seeing - in file names :) may be because - are used for options... sometimes seen using _ but typing this requires to type on SHIFT...

jinevening commented 4 years ago

@seanshpark I got it. For now, I will use circle-quantizer for the consistency with circle-inspect, circle-verify, etc. I will avoid using _ as much as possible :)

jinevening commented 4 years ago

I close this issue because all tasks were done.