search

Samsung / ONE

On-device Neural Engine
Other
428 stars 152 forks source link

[mir] Do we still need mir-related components? #9461

Open binarman opened 2 years ago

binarman commented 2 years ago

What?

I propose to delete https://github.com/Samsung/ONE/tree/master/compiler/mir and related components from source code.

Why?

This is an old part of the project, and I am not sure if someone still need this. It breaks time to time and requires maintenance.

+cc @seanshpark

seanshpark commented 2 years ago

Source itself is in the history and existing release archive files. It's OK for me to deprecate mir.

CC @lemmaa

lemmaa commented 2 years ago

... It breaks time to time and requires maintenance.

@binarman , Is that a big burden? Does this module have no build dependencies from other modules we need? How about just excluding it from the default build target without deleting the source code? Of course, it will require a lot of modifications to use it again in the future.

seanshpark commented 2 years ago

How about just excluding it from the default build target

We can revise CMake to skip the module if CMakeLists.txt is absent (by renameing it)