search

Samsung / Tizen.CircularUI

Tizen Wearable CircularUI project is to develop an open source software motivate software developer to creating Tizen Wearable Xamarin Forms app more easily and efficiently.
Other
80 stars 32 forks source link

System.Environment.NewLine should insert a new line everywhere possible #325

Closed axa88 closed 4 years ago

axa88 commented 4 years ago

Describe the bug Similar to issue #250 , the System.NewLine does not work in a Toast

Toast.DisplayText($"ABC{System.Environment.NewLine}DEF", 0);

Result: image

To Reproduce Steps to reproduce the behavior:

  1. Create a Toast as above for example in CirclePage
  2. Observe result in screenshot

Expected behavior System.Environment.NewLine always inserts a new line no matter where it is used.

Screenshots see above

Environment (please complete the following information):

myroot commented 4 years ago

I recommend to use <br> instead of newline

axa88 commented 4 years ago

I recommend to use <br> instead of newline

This is what I have been doing until I found a dependancy using newline. I can't change this. I would need to search and replace which is not optimal.

myroot commented 4 years ago

Basically, Text of toast support a simple html tag. So, I think we do better to use tag instead of newline .

App developer also can change Text color with tag like below "<span color=red>Toast</span><br>",

myroot commented 4 years ago

It is not Bug, but a kind of API design and policy and we can decide which policy was used.

axa88 commented 4 years ago

Ok. Perhaps you have valid reasoning, which I don't see. Some view use standard .net text, some view does not. Ultimately I will need to develop custom translation layer just for toast. This seems to me inconsistent