Samsung / Tizen.NET

Welcome to Tizen .NET
Other
210 stars 30 forks source link

Fix merge manifest error #267

Closed JoonghyunCho closed 7 months ago

JoonghyunCho commented 10 months ago

Fix merge manifest error when main project doesn't have privileges and acount.

Updated code is following

                    else if (subapp.Name.LocalName == "privileges")
                    {
                        if (mainDoc.Root.Element(ns + "privileges") == null)
                        {
                            mainDoc.Root.Add(subapp);
                        }
                        else
                        {
                            mainDoc.Root.Element(ns + "privileges").Add(subapp.Descendants(ns + "privilege"));
                        }
                    }
                    else if (subapp.Name.LocalName == "account")
                    {
                        if (mainDoc.Root.Element(ns + "account") == null)
                        {
                            mainDoc.Root.Add(subapp);
                        }
                        else
                        {
                            mainDoc.Root.Element(ns + "account").Add(subapp.Descendants(ns + "account-provider"));
                        }
                    }
sung-su commented 9 months ago

Thank you for the fixing ! But, it seems that there is a problem with CRLF - LF. In a typical C# project, only the sln file is enforced to have CRLF. (https://github.com/dotnet/templating/issues/1248) But it would be good to have it decided. If you had to choose one, which one do you prefer, CRLF or LF?

JoonghyunCho commented 7 months ago

@sung-su Thanks, I updated the code format as it was.