search

Samsung / TizenRT

TizenRT is a lightweight RTOS-based platform to support low-end IoT devices
Apache License 2.0
562 stars 561 forks source link

build/configs/rtl8730e, os/board/rtl8730e: Move data to external flash #6190

Closed edwakuwaku closed 2 months ago

edwakuwaku commented 2 months ago
sunghan-chang commented 2 months ago

@edwakuwaku Could you elaborate this more? Is it the data which is in the "ftl" partition? The "data" is the "BT FW patch"? There is no change on the partition map, but you set another 128KB in the external flash. Could you let me know where it moves from? Is this working well without external flash?

edwakuwaku commented 2 months ago

Hi @sunghan-chang ,

The data is not in the "ftl" partition, it is included in the kernel binary. Currently, we have yet to find other data's that can be included into the data binary, thus BT FW patch is equivalent to the whole data binary. The partition map is not needed to be changed, we are extracting the data which was included in the kernel binary, and move out to the external flash. As you can see, the changes are covered under the macro CONFIG_SECOND_FLASH_PARTITION, which means only if there is external flash, we will move the data out, or else it will still be included in kernel binary.

I hope this clear your doubts.

edwakuwaku commented 2 months ago

I tested with/without external flash, both are working fine from my side.

sunghan-chang commented 2 months ago

@edwakuwaku Thank you for explanation. It's clear for me. Can I merge this now?

edwakuwaku commented 2 months ago

@edwakuwaku Thank you for explanation. It's clear for me. Can I merge this now?

Yes please~

sunghan-chang commented 2 months ago

@edwakuwaku Sorry but are you able to leave kernel package size change in the commit description?

edwakuwaku commented 2 months ago

Hi @sunghan-chang , done, please check~