Samsung / TizenRT

TizenRT is a lightweight RTOS-based platform to support low-end IoT devices
Apache License 2.0
561 stars 560 forks source link

os/board/rtl8720e&rtl8721csm&rtl8730e: Flash Protection #6227

Closed ZhenBei-Sin closed 2 weeks ago

ZhenBei-Sin commented 1 month ago

os/board/rtl8720e&rtl8721csm&rtl8730e: Modify defconfig for Flash Protection

Change Note:

apps/examples/board_specific_demo: Enhance the Secure Storage Area example

Change Notes:

ZhenBei-Sin commented 1 month ago

Hi @sunghan-chang ,

As previously discussed at the PR. Enhance for the sstorage example.

Attached verification: image rtl8730e_FlashNonProtect.log rtl8730e_FlashProtected.log

image rtl8721csm_FlashProtected.log rtl8721csm_FlashNonProtect.log

ZhenBei-Sin commented 2 weeks ago

Let's split 1st commit for os change and config change.

The os part change is located at the ftl.c file, defining a macro and will be replaced by CONFIG_xxx

define FLASH_STATUS_BITS CONFIG_FLASH_STATUS_BITS

If we separate it into 2 commits, CONFIG_FLASH_STATUS_BITS will be undefined and leading to a compilation error. Should we proceed with this separation?

sunghan-chang commented 2 weeks ago

@ZhenBei-Sin You mean that when we split it to 2 commits and we get just one commit for os without config, it will cause build break. Is that right what you mean? If right, yes. Even it causes, let's split them.

ZhenBei-Sin commented 2 weeks ago

@ZhenBei-Sin You mean that when we split it to 2 commits and we get just one commit for os without config, it will cause build break. Is that right what you mean? If right, yes. Even it causes, let's split them.

Hi @sunghan-chang my mistake.. it should not be affect. defconfig add the config name -> os part with remain the config name (1st commit) os part change the name (2nd commit)

Done separated the commit. For the flash protection 512KB, may I know still have any unclear part?

Thank you.