search

Samsung / TizenRT

TizenRT is a lightweight RTOS-based platform to support low-end IoT devices
Apache License 2.0
566 stars 571 forks source link

Resolve warning during compilation for all rtl8721csm configs #6266

Closed Kr159 closed 3 months ago

Kr159 commented 3 months ago

made necessary changes in os folder to resove the warnings

edwakuwaku commented 3 months ago

This changes is not specific to rtl8721csm. Please revise your PR title.

edwakuwaku commented 3 months ago

There is a typo in your commit description: resove -> resolve

edwakuwaku commented 3 months ago

Hi @Kr159 , for the changes regarding comments, you shouldn't push another commit, because those are within the same scope of your first commit... Instead, you should amend your first commit and force push again... So you can keep relevant changes in just one commit..

r-prabu commented 3 months ago

@Kr159 make sure for the review fixes amend the changes in the first commit.

edwakuwaku commented 3 months ago

Hi @Kr159 , the PR title is still not changed..

Kr159 commented 3 months ago

Hi @Kr159 , the PR title is still not changed..

Hi @edwakuwaku , I changed PR Title from "Resolve warnings for rtl8721csm" to "Resolve warning during compilation for all rtl8721csm configs".