os/board/rtl8730e: Update BSP driver irq priority running on cortex-A

Samsung / TizenRT

TizenRT is a lightweight RTOS-based platform to support low-end IoT devices

Apache License 2.0

561 stars 560 forks source link

os/board/rtl8730e: Update BSP driver irq priority running on cortex-A #6269

Closed edwakuwaku closed 6 days ago

edwakuwaku commented 1 week ago

Currently the driver priority setting is according to cortex-M value range (ie. NVIC), but rtl8730e is running on cortex-A, which has it's own value range for setting irq priority (ie. GIC).
This PR revise the wrong usage on irq priority for peripheral drivers
Due to performance issue, Increase irq priority level for LCDC

edwakuwaku commented 1 week ago

How about other places in code where we are using the old system? For example amebasmart_serial.c, etc..

Ya, that should be changed as well... Thank you for reminding

r0bindal commented 1 week ago

we are getting same performance in both sample app and benchmark app with and without this pr

Sample - 16ms (60fps) measured using rtc Benchmark - 50fps are shown on UI

edwakuwaku commented 1 week ago

Hello @r0bindal , thanks for updating the results. May I know the LCD result is tested individually without Bixby audio? For this PR, I expect that when LCD + Bixby is up and running together with other driver modules, both LCD and Bixby can be prioritised. I am not sure whether are you aware of that, but currently the parameter settings for LCD is according to 60FPS. Thus, the test results is making sense to me.

sunghan-chang commented 6 days ago

@edwakuwaku We've verified that this and PR #6271 resolves external flash hang. I am going to merge if possible. Is there any reason to mark DO NOT MERGE?

edwakuwaku commented 6 days ago

@edwakuwaku We've verified that this and PR #6271 resolves external flash hang. I am going to merge if possible. Is there any reason to mark DO NOT MERGE?

In the second commit of this PR, I would like to check whether it works better if we increase the irq priority for driver used by bixby audio and LCD. But it seems it was not tested together yet. Anyway, since that will not affect normal operation, it can be merged.