search

Samsung / rlottie

A platform independent standalone library that plays Lottie Animation.
Other
1.17k stars 225 forks source link

Dead lock is here #141

Closed overtake closed 5 years ago

overtake commented 5 years ago

So. dead lock still there ;(

image

overtake commented 5 years ago

So. weird thing is there. Sometimes this file has artefacts (right eye). Its looks like problem in parsing model because if we relaunch app and try to play again (without cached model) its may be fine or with artefact (doesn't matter creating new player or not)

image

smohantty commented 5 years ago

@overtake , I tested by disabling the threading (by commenting LOTTIE_THREAD_SUPPORT in config.h) but the occasional hang is still there. Yet to figure out on which frame it occurs . looks like the final path calculation after transform resulting some path that freetype raster is unable to process.

If the eye is the problem . could you please create a resource file by disabling all other layer except right eye. and send it to me for further debugging. or you can send me the AE file if thats ok with you . either one will help.

overtake commented 5 years ago

can you reproduce the hang?

i asked the illustrator for source file

overtake commented 5 years ago

the another thread always stuck here

image

perhaps problem is here: image

image

smohantty commented 5 years ago

Yes I can reproduce it .. its in the freetype raster code. just want to know which path causing this.

smohantty commented 5 years ago

will wait for the resource file

overtake commented 5 years ago

@smohantty there is a source file bunnyta kiss cutted 2.aep.zip

overtake commented 5 years ago

the sticker contains bones (controller) maybe its connected?

smohantty commented 5 years ago

@overtake , am using After Effect CC 2018. the AEP file you provided is created using a newer version. Could you ask them to save it as CC(18) or lower and send it to me.

Thanks

overtake commented 5 years ago

bunnyta kiss cutted 2 copy CC (15.x).aep.zip

smohantty commented 5 years ago

@overtake , one update .. in Layer "eyes" -> "blue outline" --> group6 --> path1 uses expression for path animation. we don't support expression in rlottie. I don't know if that is the problem or something else . need to debug more tomorrow. FYI , I see usage of "merge path" and expression in the AE file . currently rlottie dosen't support both.

overtake commented 5 years ago

Ok, thanks you very much. Waiting updates. More import to explore deadlock and find what the break the calculations.

smohantty commented 5 years ago

@overtake , I have pushed a fix for the same .. it was silly typo which was causing invalid memory access :(

overtake commented 5 years ago

Great to hear it. Thank you for you work!

On Wed, 19 Jun 2019 at 02:11, Subhransu notifications@github.com wrote:

@overtake https://github.com/overtake , I have pushed a fix for the same .. it was silly typo which was causing invalid memory access :(

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Samsung/rlottie/issues/141?email_source=notifications&email_token=AAJT2MST7UJKHSMH6MNQ75LP3F2SBA5CNFSM4HY5QJBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYAJ3TI#issuecomment-503356877, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJT2MRSDW7GYJXFA5CK22LP3F2SBANCNFSM4HY5QJBA .

overtake commented 5 years ago

So... About simple typos...

image

overtake commented 5 years ago

Hm now she's right eye is gray. its blue on one frame. image

smohantty commented 5 years ago

@overtake , Sorry was too much into the dead lock :) .. Have push a patch to take care of the scenario when we transition from 1 shape to other (of different size).

overtake commented 5 years ago

i understand, small typos can take such lot of time. But! Finally fixed! Thank you man! Also i'm using your framework in Telegram messenger (macos.telegram.org) for playing animated stickers in chat. and its working fasten than any other frameworks.

smohantty commented 5 years ago

@overtake , Wow that's great news :) Is it already part of the MacOS Telegarm Application. Would like to check it out :)

overtake commented 5 years ago

https://rink.hockeyapp.net/apps/6ed2ac3049e1407387c2f1ffcb74e81f

here you can test a lot stickers it in beta. https://t.me/topanimated channel.

smohantty commented 5 years ago

thanks :)

hermet commented 5 years ago

@overtake Is it open source code? Could you share me the link? I'd like to see how rlottie is integrated in your project.

overtake commented 5 years ago

@hermet is it. but i'm updating code on git after each release.

https://github.com/overtake/TelegramSwift

i just made a new submodule and project for rlottie. For example here how i pulling the frames from the library. And for playing i have wrote player which pulling frames in background to samplebuffer

image