search

Samsung / rlottie

A platform independent standalone library that plays Lottie Animation.
Other
1.13k stars 223 forks source link

Delete vs2019 solution? #431

Open nokeya opened 3 years ago

nokeya commented 3 years ago

I think using cmake for MSVC 2019 is perfectly fine. Why keep maintaining separate solution?

Also, with #430 merged cmake will be usable for static builds too.

I build rlottie for msvc2019 with following command:

cmake .. -DBUILD_SHARED_LIBS=OFF -DCMAKE_BUILD_TYPE=Debug -G "Visual Studio 16 2019" -A Win32

where

Run command then open build\rlottie.sln to build the solution.

Maybe it can be added to readme?

hermet commented 3 years ago

the vs solution is added for users who are only accustomed to vs studio, sure you can add to readme, and the guide helps to win users, we can remove it.

wh1t3lord commented 3 years ago

It doesn't make any sense, because Windows provides Visual Studio for generation project. More important just keep save projects without generating them through cmake, because sometimes and somewhere it's hard to get the right version of Visual Studio's solution.

Close this issue please.

nokeya commented 3 years ago

sometimes and somewhere it's hard to get the right version of Visual Studio's solution

So you just generate it with Cmake for your needs - VS version, build arch, build type

wh1t3lord commented 3 years ago

sometimes and somewhere it's hard to get the right version of Visual Studio's solution

So you just generate it with Cmake for your needs - VS version, build arch, build type

You don't understand me. It will hard to generate project for VS, why do you need to have deleted solution when it is already exist?

wh1t3lord commented 3 years ago

sometimes and somewhere it's hard to get the right version of Visual Studio's solution

So you just generate it with Cmake for your needs - VS version, build arch, build type

For example it is hard to generate solution for 2019 version on CEF.

wh1t3lord commented 3 years ago

Windows doesn't have installed cmake as default application. It is another culture to use projects written for windows too. It is quite easy just open solution which placed in repository rather than generate it through cmake.

nokeya commented 3 years ago

Project from repo can only build x64 dynamic library. It is not enough. If you want something more or other - you will need to recreate or generate VS solution by yourself

wh1t3lord commented 3 years ago

Project from repo can only build x64 dynamic library. It is not enough. If you want something more or other - you will need to recreate or generate VS solution by yourself

You can add from Visual Studio your own build type and what you want from current Configuration. If you are not a windows's user you may close this issue, because it doesn't affect you at all, you only use cmake or similar stuff.