search

Samsung / rlottie

A platform independent standalone library that plays Lottie Animation.
Other
1.18k stars 225 forks source link

Optimize compatibility with windows #470

Closed xspeed1989 closed 3 years ago

xspeed1989 commented 3 years ago

1.On windows, stbi__fopen opens a path containing non-English characters or symbols will fail due to encoding problems, so the filename parameter is assumed to be utf-8 and converted to utf-16, and then call _wfopen_s or _wfopen

  1. In Windows 7 multithreading mode, unloading rlottie.dll will cause the process to be stuck and unable to exit. You need to actively stop RleTaskScheduler before main return
wangwenx190 commented 3 years ago

+1

wangwenx190 commented 3 years ago

@smohantty Can you have a look? Thanks!

MouriNaruto commented 3 years ago

Looks good. But I think your implementation should be polished.

smohantty commented 3 years ago

@xspeed1989 , Thanks for the patchs . could you please split into 2 separate commit and request for review separately so that it will be easy to track and test.

  1. patch for handling non-utf8 file path.
  2. dynamic unloading of library in multi threading scenario.
xspeed1989 commented 3 years ago

@xspeed1989 , Thanks for the patchs . could you please split into 2 separate commit and request for review separately so that it will be easy to track and test.

  1. patch for handling non-utf8 file path.
  2. dynamic unloading of library in multi threading scenario.

@smohantty ok, I will do it, thanks for review

xspeed1989 commented 3 years ago

the pr will be re-commit for easy track and test