search

Samsung / rlottie

A platform independent standalone library that plays Lottie Animation.
Other
1.15k stars 223 forks source link

Performance regression with Blendmode introduction #545

Open christoph-hart opened 1 year ago

christoph-hart commented 1 year ago

It appears that the commit that introduces the AfterEffects blend mode simulation vastly decreases the performance of the renderer.

https://github.com/Samsung/rlottie/commit/19164367c99363d4b86ecc93b1bbc318faff2a4a

JSUYA commented 1 year ago

Hi @mihashco @JoogabYun Can you review this issue and performance check? https://github.com/Samsung/rlottie/commit/19164367c99363d4b86ecc93b1bbc318faff2a4a#commitcomment-121705281

JoogabYun commented 1 year ago

Yes we are taking this seriously. We are trying to improve.

smohantty commented 1 year ago

I think the patch makes every layer rendering goes through intermediate buffer instead of only layers which needs this ( has blending mode ) . I think it will be better to revert this patch and put one slow path only for the particular usecase.

JoogabYun commented 1 year ago

Fixed with this patch. https://github.com/Samsung/rlottie/pull/546

KonstantinRitt commented 2 months ago

fixed by f969abf62c8df773e3951a1176000e70fcde637f