Samsung / walrus

WebAssembly Lightweight RUntime
Apache License 2.0
40 stars 10 forks source link

Fix an error in float not equal operation #75

Closed gergocs closed 1 year ago

gergocs commented 1 year ago

Signed-off-by: Gergo Csizi gergocs@inf.u-szeged.hu

zherczeg commented 1 year ago

Please add some tests

gergocs commented 1 year ago

Patch is ready for review

zherczeg commented 1 year ago

How do you detected this issue? Normally, a not equal should fail if either is nan, but it will return with true here. In other words !(a == b) is not the same as (a != b) for float numbers.

gergocs commented 1 year ago

The reference manual says the not equal operation should be unordered or not equal.