search

Samsung / webIDE-common-tizentv

This is a common lib project for VScode/Atom extension and Wits, providing build, install, launch web project and certificate manager.
Apache License 2.0
11 stars 12 forks source link

execute should potentially be changed to was_execute #22

Open AndreasNasman opened 2 years ago

AndreasNasman commented 2 years ago

I think that the execute part of this command

https://github.com/Samsung/webIDE-common-tizentv/blob/8e3b4acd9f20436527fe233d8aadc1ba98b39b4e/lib/appLauncher.js#L99

can be changed to was_execute to support older Tizen devices.

The above-mentioned command fails when using vscode-extension-tizentv (that uses this module under the hood) on e.g. an HG43EF690DBXEN Hotel TV. was_execute works on that TV and on newer Tizen models too.

I found the was_execute command from reading the source code of Samsung Wits: https://github.com/Samsung/Wits/blob/a3d1c32b07d8a0bff176ddc08228c11e07cdc963/lib/appLaunchHelper.js#L55

I'm not sure why it works or why the command has changed on newer Tizen devices. I haven't been able to find a list of valid commands (like was_execute or execute) anywhere.

Thanks, – Andreas