SamsungDS / Spex

lint- and extract figures from NVMe specification documents.
https://samsungds.github.io/Spex/
3 stars 2 forks source link

feat(docker,mk): add a Docker container wrapping the nix environment #17

Closed safl closed 1 year ago

safl commented 1 year ago

I wanted to create this as a DRAFT PR, as it is only for input to our offline discussion, however, for some reason that is currently not possible. The point of the docker-image:

The goal is to as the Makefile does, provide a "make docker" which should just drop into nix develop .#, thus providing the same development environment, as provided by nix, but via docker.

However, this does not work. For some reason running nix develop .# -c true fails.

safl commented 1 year ago

@jwdevantier thanks for fixing this up! It now fails due to the docs-check failing.

safl commented 1 year ago

I took the liberty of re-writing history because it looked so very wrong and I could not make sense of the changes made.

safl commented 1 year ago

Ah, the make docs check fails because linkcheck fails... because the repository is not publicly available....