search

SamsungInternet / support

For general Samsung Internet support. You can use the Issues register here as a way to ask support questions.
MIT License
17 stars 0 forks source link

theme-color meta tag text colour #15

Closed AverageMarcus closed 6 years ago

AverageMarcus commented 7 years ago

Version: 6.2.00.38

When using some light colour for the theme-color meta tag such as #f7df1e (JS Yellow) the text colour is set to white, causing the URL and icons to be hard to see. The same page in Chrome for Android renders with black text.

Example page: http://output.jsbin.com/pubedewuri

E.g. Samsung Internet image

Chrome for Android image

I have also seen this on some light greys and similar colours.

Ideally, for any colour specified in the theme-color meta tag, the rendered text colour should pass the WCAG AA colour contrast test.

poshaughnessy commented 7 years ago

Thank you for reporting this @AverageMarcus and sorry for the slow reply, I've mentioned this briefly to our HQ colleagues already and it's Chuseok this week but I'll follow up again soon!

NB. The live preview of the JSBin has expired, so I recreated it here:

https://poshaughnessy.github.io/theme-color-meta-tag-test/ https://github.com/poshaughnessy/theme-color-meta-tag-test

AverageMarcus commented 7 years ago

Ah! Didn't realise I wasn't logged in to JSBin. Thanks to recreating!

poshaughnessy commented 7 years ago

Hi again @AverageMarcus, just for the record, to let you know this has been raised internally too.

poshaughnessy commented 6 years ago

We've been informed that this has been resolved now, so should go out in a future release soon. I'll close this to keep our open issues list to unresolved items, but if I hear of the release date for it I'll comment with further info then. Thanks again for raising!

poshaughnessy commented 6 years ago

Hi @AverageMarcus. I think this is resolved now? I can see black text now, with both v6.4 and v7.2 Beta (screenshots below). If you still spot an issue though, please LMK!

v6.4

v7.2 Beta

AverageMarcus commented 6 years ago

👍 looks good! Nice work!