search

SamsungInternet / support

For general Samsung Internet support. You can use the Issues register here as a way to ask support questions.
MIT License
17 stars 0 forks source link

document.getElementsByClassName.ToString is not a function #56

Closed symi closed 6 years ago

symi commented 6 years ago

Hi,

We've been experiencing a large number of browser errors on our site coming from what looks like the new version of Samsung Internet starting around June 15th.

Example reproduction steps are to go to: https://www.onthebeach.co.uk/about-us and the error should happen on page load.

The error message is: document.getElementsByClassName.ToString is not a function.

I'm afraid the only stacktrace we have is in function (a,b,d,k,l).

The error is coming from browsers with the user agent string similar to: Mozilla/5.0 (Linux; Android 7.0; SAMSUNG SM-G935F Build/NRD90M) AppleWebKit/537.36 (KHTML, like Gecko) SamsungBrowser/7.2 Chrome/59.0.3071.125 Mobile Safari/537.36 (Which I believe is the new version of Samsung Browser?)

It also looks like its happening on a wide range of Samsung devices, SM-G935F, SM-G950F, SM-A520F etc and Android versions 5, 6, 7 and 8.

I believe this isn't an error with our site and that its coming from the browser.

Let me know if you need any more information

poshaughnessy commented 6 years ago

Hi.

We'll update here again when v7.4 is released to stable.

v7.4 has now been released, which should mean that these errors should have significantly dropped off now. (You should only see them from a small minority of users who haven't updated yet - and this small amount should continue to tail off).

If this is not the case though, please let us know.

symi commented 6 years ago

Thanks @poshaughnessy. I'm thinking we could be getting to a resolution of this issue now, we will monitor errors and if all looks good we can close this issue 🎉

symi commented 6 years ago

@poshaughnessy Sorry for taking so long getting back to you on my previous comment.

I can confirm our site works without error in v7.4 and error rates seem to have reduced. Thanks for sorting this out.

webbower commented 6 years ago

Same. The error has almost entirely disappeared from our logs. ~100 times in the last 24 hours. Down from hundreds of times per day.

deweydb commented 5 years ago

Still see this bug kicking about, so we've got this in our codebase for now for users who haven't upgraded.

// Patch for Samsung Internet (Browser) V 7.2
// see: https://github.com/SamsungInternet/support/issues/56
if(navigator.userAgent.match(/SamsungBrowser\/7\.2/i)){
  Function.prototype.ToString = function () { return this.toString(); }       
}
niklasHagner commented 2 years ago

I've been seeing some of this recently, but very small amounts (below 30 per day on a large site)