SamsungLabs / NeuralHaircut

Neural Haircut: Prior-Guided Strand-Based Hair Reconstruction. ICCV 2023
Other
516 stars 48 forks source link

Scaling parameter, NeuS Space ? #23

Open Suho0922 opened 1 month ago

Suho0922 commented 1 month ago

I have some question for implemenetation

  1. Why do we have to set the camera parameter that scales the point cloud in unit sphere?

  2. why do we have to change the axis for NEUS space? https://github.com/SamsungLabs/NeuralHaircut/blob/1dbdd07797458e6e0000bd3a02f3092d419d1756/src/multiview_optimization/runner.py#L202

Vanessik commented 1 month ago
  1. In basic NeUS code implementation, all scenes were scaled to a unit sphere, so it was easier to scale all our captures to the unit sphere as well.

  2. I think it happened because of different coordinate systems in OpenCV and pytorch3d, but I don't remember for sure