SamsungLabs / tr3d

[ICIP2023] TR3D: Towards Real-Time Indoor 3D Object Detection
Other
141 stars 8 forks source link

Matching procedure #24

Closed florianlanger closed 6 months ago

florianlanger commented 6 months ago

Hi Danila, Thanks for your great work! How exactly does the matching procedure work during training ? What predictions are matched to GT objects and which are not ? Is there a distance cut off i.e. if the predicted bounding box center is more than some distance from the nearest GT bounding box it does not get matched ? When searching for the matching GT box is only that category considered which has the highest predicted probability ? Is NMS applied also during training ? I only saw a parameter for the nms threshold specified for test time. Thank you!

filaPro commented 6 months ago

Hi @florianlanger , We don use NMS during training. Have you followed the matching function code here? We have 3 conditions there to match gt and predicted boxes.

florianlanger commented 6 months ago

Thanks for pointing me to this! So the way I understand it now is that each GT bounding box gets assigned the top_pts_threshold=6 closest predictions (at the right feature level depending if objects from that category are typically small or large) and it is also ensured that each prediction is only assigned to its closest GT bounding box, but not to multiple ones. Is that correct ?

filaPro commented 6 months ago

yes, that's right