SamuelScheit / puppeteer-stream

A Library for puppeteer to retrieve audio and/or video streams
MIT License
335 stars 105 forks source link

Errors with Typescript #36

Closed euberdeveloper closed 2 years ago

euberdeveloper commented 2 years ago

When transpiling with Typescript I obtain these errors:

node_modules/puppeteer-stream/dist/PuppeteerStream.d.ts:2:8 - error TS1192: Module '"/home/euber/Github/bbb-video-scraper/node_modules/puppeteer-stream/node_modules/puppeteer/lib/types"' has no default export.

2 import puppeteer, { LaunchOptions, Page, BrowserOptions, ChromeArgOptions } from "puppeteer";
         ~~~~~~~~~

  node_modules/puppeteer-stream/node_modules/puppeteer/lib/types.d.ts:7097:10
    7097          export * from "devtools-protocol/types/protocol";
                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    'export *' does not re-export a default.

node_modules/puppeteer-stream/dist/PuppeteerStream.d.ts:2:42 - error TS2305: Module '"puppeteer"' has no exported member 'BrowserOptions'.

2 import puppeteer, { LaunchOptions, Page, BrowserOptions, ChromeArgOptions } from "puppeteer";
                                           ~~~~~~~~~~~~~~

node_modules/puppeteer-stream/dist/PuppeteerStream.d.ts:2:58 - error TS2305: Module '"puppeteer"' has no exported member 'ChromeArgOptions'.

2 import puppeteer, { LaunchOptions, Page, BrowserOptions, ChromeArgOptions } from "puppeteer";
                                                           ~~~~~~~~~~~~~~~~

node_modules/puppeteer-stream/dist/PuppeteerStream.d.ts:8:5 - error TS2416: Property 'destroy' in type 'Stream' is not assignable to the same property in base type 'Readable'.
  Type '(page?: Page | undefined) => Promise<void>' is not assignable to type '(error?: Error | undefined) => this'.
    Types of parameters 'page' and 'error' are incompatible.
      Type 'Error | undefined' is not assignable to type 'Page | undefined'.
        Type 'Error' is missing the following properties from type 'Page': _closed, _client, _target, _keyboard, and 129 more.

8     destroy(page?: Page): Promise<void>;
      ~~~~~~~

Found 4 errors.

Version of ts: 4.5.5 Version of your lib: 2.0.8

euberdeveloper commented 2 years ago

Hi, I've just tried. It fixes all of those errors but one:

node_modules/puppeteer-stream/dist/PuppeteerStream.d.ts:8:5 - error TS2416: Property 'destroy' in type 'Stream' is not assignable to the same property in base type 'Readable'.
  Type '() => Promise<void>' is not assignable to type '(error?: Error | undefined) => this'.
    Type 'Promise<void>' is not assignable to type 'this'.
      'this' could be instantiated with an arbitrary type which could be unrelated to 'Promise<void>'.

8     destroy(): Promise<void>;
      ~~~~~~~

Found 1 error.

I can't reopen the issue so I create a new one.