ability to use puppeteer-extra plugins like stealth

[ganganimaulik]

47

I had to reload extension on browser load for some reason when we provide puppeteer-extra package. not sure why extension is not getting detected without reloading here: https://github.com/ganganimaulik/puppeteer-stream/blob/main/src/PuppeteerStream.ts#L79

anyway it's working fine as per example added: https://github.com/ganganimaulik/puppeteer-stream/blob/feat/extra-plugin/examples/puppeteer-extra.js

[SamuelScheit]

Thank you very much for your contribution!

[ganganimaulik]

Thank you very much for your contribution!

you're welcome :)

[thomask]

This change introduces a BC break

Is this intentional?

Also arg1 naming is not clear

[ganganimaulik]

This change introduces a BC break

Is this intentional?

Also arg1 naming is not clear

made pr to make second arg optional for ts #51 -> cant think of variable name feel free to suggest, make pr. lol

[thomask]

That was fast 😀

However (without having tested) I think the BC break is still there, because my opts, which were/are passed as the first argument, are not being passed to puppeteer.launch.

Perhaps you meant to launch with the first argument in case Puppeteer is not passed as the first argument?

[ganganimaulik]

  const browser = await launch({
    defaultViewport: null,
    devtools: true,
  });

if I try to pass arguments like this, it's working fine for me - shows devtools (without new pr). not sure what you're talking about.

[thomask]

My bad, I had missed these lines