SamuelScheit / puppeteer-stream

A Library for puppeteer to retrieve audio and/or video streams
MIT License
335 stars 105 forks source link

little refactoring and fix for tab index #55

Closed simllll closed 1 year ago

simllll commented 2 years ago

fixes https://github.com/Flam3rboy/puppeteer-stream/issues/41

SamuelScheit commented 2 years ago

thank you for your contribution, however you use the getTargetInfo function which is not available in puppeteer

simllll commented 2 years ago

Ah right, sorry for this, I'm using puppeteer 15, there is this the only valid option. We could feature detect it :-) i will add a commit next week for it

shokhboz-abdullaev commented 1 year ago

Hello, I was also facing the same issue with tabs, is there any news?

SamuelScheit commented 1 year ago

Thank you very much for taking time to make the PR. I've tested it, added two type fixes and reformatted the code.

The updated version is published under version 2.1.3

npm i puppeteer-stream@2.1.3