search

SamuelScheit / puppeteer-stream

A Library for puppeteer to retrieve audio and/or video streams
MIT License
333 stars 105 forks source link

Discussion: Wanted to understand why recorder is global variable here #78

Closed asim-aashish closed 1 year ago

asim-aashish commented 1 year ago

https://github.com/Flam3rboy/puppeteer-stream/blob/10ea8e918119f01f5d7028b77d082c963ab2b342/extension/background.js#L30

SamuelScheit commented 1 year ago

You are right, this is actually not intended, recorder should be local and then be saved in the global recorders object.