search

SamuelSchlesinger / commander-cli

A simple library I wrote to allow me to quickly and easily construct command line interfaces.
MIT License
29 stars 2 forks source link

Better Tests #3

Open SamuelSchlesinger opened 4 years ago

SamuelSchlesinger commented 4 years ago

I just expand the unit testing that I'm doing right now, and maybe include one integration tests with runningtask-manager or something.

BebeSparkelSparkel commented 3 years ago

I converted all the tests to hspec in #15, maybe this should be split into two pulls.

Take a look and let me know what you think.

SamuelSchlesinger commented 3 years ago

Will do! Sorry for taking so long to reply again, I've been busy with work and holiday stuff.

SamuelSchlesinger commented 3 years ago

That one was closed, telling me which one covers it would be helpful.

BebeSparkelSparkel commented 3 years ago

Most of the new PRs have the hspec tests already and have been rebased to have the hspec tests

SamuelSchlesinger commented 3 years ago

Can you tell me the best order in which to read the PRs? As I now see them, some are far too large for me to feel comfortable with merging as they are.

BebeSparkelSparkel commented 3 years ago

oldest to newest. If that is too much let me know

SamuelSchlesinger commented 3 years ago

I think that's fine, actually. I am waiting to hear back from you on the oldest now.

BebeSparkelSparkel commented 3 years ago

I have restructured most off the pull requests and removed the PRs that you indicated had too many changes. This starts with PR #31 and each PR lists which PR should precede it.