search

SamuelYvon / netifaces-2

netifaces reborn
https://pypi.org/project/netifaces2/
MIT License
21 stars 7 forks source link

Switching to ubuntu-20.04, manylinux 2_17 for abi3 #12

Closed martinhoyer closed 1 year ago

martinhoyer commented 1 year ago

I was not able to reopen the last PR, sorry for the mess.
What I've learned is that building cp37 abi wheels on higher python versions was not the greatest idea, as the wheels were bot being able to be installed when I tried RHEL-7.9 with rh-python38. Again, sorry!
With ubuntu-20.04 and manylinux 2_17 (aka 2014), it works fine. I've also tried python3.7 on Fedora and that works fine also.

Manylinux 2_17 will be EOL June 2024, so I'd propose keeping it till then, as it allows also building ppc64, i686.

To add to this, I find building ppc64 (not le) as part of the cp36 "legacy" would be just too much trouble, as manylinux-cross does not copy python from manylinux images for armv7l and ppc64 as it does for the rest and there simply is not python3.6.

Removing the workaround line, as it was fixed upstream.

The missing AF_ seems to fixed by your changes, thanks!

SamuelYvon commented 1 year ago

The missing AF_ seems to fixed by your changes, thanks!

See https://github.com/SamuelYvon/netifaces-2/issues/13 as it might impact you. I'll check over the changes shortly :)