search

SamuelYvon / netifaces-2

netifaces reborn
https://pypi.org/project/netifaces2/
MIT License
21 stars 7 forks source link

Type information mismatch #16

Closed dries007 closed 1 year ago

dries007 commented 1 year ago

In the rust library the netmask is called "mask" and so it's passed to Python that way, but the Python type definition has Literal["netmask"] instead.

I propose you change Literal["netmask"] to Literal["mask"] to not break existing scripts, thanks.

(This is a deviation from the old netifaces package BTW)

SamuelYvon commented 1 year ago

Thanks for the catch. Will fix ASAP

SamuelYvon commented 1 year ago

I do not think it breaks anything however, it's only the wrong type definition (albeit confusing)

dries007 commented 1 year ago

No, it works perfectly well, but PyCharm complains about the key not exsiting and I don't like squiggly lines under my code :smile:

Thanks for maintaining this BTW.

SamuelYvon commented 1 year ago

I don't like squiggly lines under my code

That makes two of us ;)

SamuelYvon commented 1 year ago

Fixed in 0.0.16 :)