search

SamuelYvon / netifaces-2

netifaces reborn
https://pypi.org/project/netifaces2/
MIT License
21 stars 7 forks source link

Adding aarch64, ppc64 py36 wheels #8

Closed martinhoyer closed 1 year ago

martinhoyer commented 1 year ago

@SamuelYvon I somehow missed python3.6 on ARM in the last PR. The use-case for it is on .el8 (RHEL-8, CentOS...). RHEL-7 is also still supported, while there is no aarch64 version, there is ppc64 (non-le), which can also be built on Manylinux2014. Would you be against adding it also, to have complete EL coverage?

Please note that when I tested wheels from my fork's CI, they did not really work, the netifaces module had no address families (all wheels, not just py36). I'm not quite sure why. Maybe something got broken in upstream? The ubuntu images got updated recently and have different rust, rust tools versions, but maybe I'm missing something.

SamuelYvon commented 1 year ago

Please note that when I tested wheels from my fork's CI, they did not really work, the netifaces module had no address families (all wheels, not just py36).

This is odd, were you testing in a container or on a local machine? I'm assuming you tried to simply call the interfaces() function and got no result?

martinhoyer commented 1 year ago

Please note that when I tested wheels from my fork's CI, they did not really work, the netifaces module had no address families (all wheels, not just py36).

This is odd, were you testing in a container or on a local machine? I'm assuming you tried to simply call the interfaces() function and got no result?

not in container. interfaces() works fine, but everything beginning with AF_ was missing.

..found some more issues in the meantime. Will investigate and report back.

SamuelYvon commented 1 year ago

not in container. interfaces() works fine, but everything beginning with AF_ was missing.

Odd. Latest wheel on x86-64 linux (ubuntu) works fine

..found some more issues in the meantime. Will investigate and report back.

Are you referring to this PR in particular?

Please let me know what you find. I am trying to setup a test pipeline (you may have noticed the other PR). For now since interest was limited I did not test in depth, but with activity picking up I'll invest more time

martinhoyer commented 1 year ago

not in container. interfaces() works fine, but everything beginning with AF_ was missing.

Odd. Latest wheel on x86-64 linux (ubuntu) works fine

Have you tried to build one now? The latest on pypi works fine for me too.

SamuelYvon commented 1 year ago

Have you tried to build one now?

No, I was using latest on pypi.

but everything beginning with AF_ was missing.

I just built it locally, it does not exposes the constants. Let me open up an issue. Your changes do not impact this so Ill merge the PR. We can move the conversation over in an issue.

martinhoyer commented 1 year ago

Oh, I was hoping to do some mote testing, but ok :)
In any case it looks like not all wheels work. I'm afk at the moment, will let you know tomorrow what I find.

SamuelYvon commented 1 year ago

@martinhoyer oh! Sorry :/ I won't do any release anyways; you feel free to re-open a PR from your branch. For the AF_ exports, I likely have the cause, so I should be able to fix that soon enough