Samueltansw / pe

0 stars 0 forks source link

invalid error message for invalid weight_used_weight_unit #10

Open Samueltansw opened 1 year ago

Samueltansw commented 1 year ago

image.png

as seen in the image, when an invalid unit is given, but correct RPS is given, the program outputs "invalid inputs for reps per set!", but should be outputing invalid weight unit

nus-se-script commented 1 year ago

Team's Response

Wrong output message but does not affect usage

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: I think it does affect usage as wrong error message will cause users to think that the unit entered is actually correct. Thus instead of modifying the unit, users will try to use enter values for RPS, which will result in the same error message stated in the bug.

image.png

The image shown can be an illustration of how users might go about troubleshooting the problem. Having typo errors such as double typing letters are quite common and thus the above bug will cause inconvenience to users.