search

Samueltansw / pe

0 stars 0 forks source link

decimal weights not allowed for /wadd command but not stated in UG #13

Open Samueltansw opened 1 year ago

Samueltansw commented 1 year ago

image.png

adding 100.3kg is not allowed but not stated in UG that only integer is allowed

nus-se-script commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unable to give decimal value for weight

Users should definitely be able to use decimal numbers for weights. It could be quite limiting to a user to only be able to track weights in whole numbers and they will be unable to accurately track their workout if they happen to use weights that are in decimal. Eg. a 1.5kg dumbell

image.png

[original: nus-cs2113-AY2223S2/pe-interim#2202] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

User is still able to track weights used (can round up/down) but tester is right that decimal would be allow for more accurate tracking

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** I don't think that the issue shoule be under NotInScope as changing the data type of weights from int to double is doable and can be done quite easily. Furthermore, limiting the weights to only integer makes the program not very usable as users have to round up / down the weights, resulting in inaccurate recording of workouts. The team should have used double instead of integer at the start of the implementation of their program, rather than waiting until the subsequent versions, as the basic functionalities of the program such as adding accurate weights, should already be implemented in their first version, v1.0 or at the very least in this version, v2.0.