search

SamuraiWTF / katana

SamuraiWTF package management tool and interface.
20 stars 8 forks source link

Juice-shop will not install #54

Closed 0ptsec closed 2 years ago

0ptsec commented 2 years ago

running katana via command line, version 5.2 of samuraiWTF, with virtualbox 6.1 . All other applications/plugins install. the below error is received after running "katana install juice-shop"

ERROR Plugin 'get_url' suffered a critical failure: could not find link pattern in resulting page.

mgillam commented 2 years ago

Hey @0ptsec, any chance it was cloned a while ago? We had a known issue previously when the juice-shop github repo moved, which would result in that error. https://github.com/SamuraiWTF/katana/issues/32

0ptsec commented 2 years ago

Thanks! I was able to work out a fix based on the current avaiable version of juice-shop. The current is looking for "node12" , any wget that I perform and review of the juice shop releases page has it all at "node14" I am able to get this to work with the following changes which are no longer version dependent.

current - not working: link_pattern: \/juice-shop\/juice-shop\/releases\/download\/.*_node12_linux_x64.tgz

modified - working: linkpattern: \/juice-shop\/juice-shop\/releases\/download\/.*node[0-9][0-9]_linux_x64.tgz

mgillam commented 2 years ago

Awesome! Appreciate the fix, will tag @JGillam to get this into https://github.com/SamuraiWTF/katana

JGillam commented 2 years ago

It appears juice shop dropped support for Node 12 last week. That's the cause of the issue. I'm actually not sure how switching to node[0-9][0-9] would fix this (at least not on the downloadable vm) because it has Node 12 installed. I'm in the process of fixing this in SamuraiWTF/samuraiwtf#170

JGillam commented 2 years ago

This was fixed in #55