SanAndreaP / BetterCombatRebirth

A continuation of the Better Combat mod from Ironfists for Minecraft 1.12.2 and beyond
HomePage
8 stars 16 forks source link

fix #15 and others #26

Open k1r0s opened 4 years ago

k1r0s commented 4 years ago

First of all, I tried to make upstream work but it doens't so i was working locally with 37bf5fab763aada857884f6fafbc00946e7f67b2 (curseforge version)

didn't tested this too much (but it works somehow) so this is a suggestion pretty much.

Simply by checking if the "default action" has implemented means to do what the player expects rather than what Minecraft expects:

sword in the offhand - bow in the mainhand > left click will attack with the offhand sword in the offhand - bow in the mainhand > right click will draw the bow in the mainhand (no attack with the offhand) https://github.com/SanAndreasP/BetterCombatRebirth/issues/15#issue-473215114 axe in the offhand - a block in the mainhand > left click will attack with the offhand bow in the mainhand - bow in the mainhand > does what you expect on vanilla mc bow in the mainhand - shield in the mainhand > does what you expect on vanilla mc sword in the mainhand - shield in the mainhand > left click will attack with the offhand

CalaMariGold commented 3 years ago

@SanAndreasP Hey there, can this be merged? Thanks!

k1r0s commented 3 years ago

Please test this carefully as there are edge cases which do not work as I expected at first glance.

I'm not an active mc player (so I can't provide help here) at the moment due to work balance