search

Sanae6 / SmoOnlineServer

Official server for Super Mario Odyssey: Online
https://discord.gg/jYCueK2BqD
108 stars 27 forks source link

fixed some typing errors #30

Closed piplup55 closed 2 years ago

Sanae6 commented 2 years ago

Lol (lmao)

TheUbMunster commented 2 years ago

whoops! copy/paste strikes again!

Istador commented 2 years ago

Three strikes and you're out: when trying to copy paste something for a third time, then instead refactor it into a function.

(Though I personally try to refactor even on the first copy paste attempt, because it might not always be that obvious how many copies there are already.)

TheUbMunster commented 2 years ago

In principle I agree, but in this case, it was a single line. I think it'd be a bit silly to replace a single line log with a method call to a function that takes up four lines. (That said, the code duplication was present before the change). I'll make sure to do that next time.