search

Sanae6 / SmoOnlineServer

Official server for Super Mario Odyssey: Online
https://discord.gg/jYCueK2BqD
108 stars 27 forks source link

new discord bot #45

Open TheUbMunster opened 1 year ago

TheUbMunster commented 1 year ago

This is a proposed solution to this bug image by switching to the Discord.net library instead of DiscordSharpPlus

initial testing seems to be fine, some tweaks and fixes will need to be made.

Istador commented 1 year ago

It should not log these messages, in the default case where there is no Discord/Token configured in the settings.json, because it will confuse users: https://github.com/Sanae6/SmoOnlineServer/blob/a5b834834c33d1fcb58d129b5c179eba1a3f643c/Server/DiscordBot.cs#L35 https://github.com/Sanae6/SmoOnlineServer/blob/a5b834834c33d1fcb58d129b5c179eba1a3f643c/Server/DiscordBot.cs#L64

I'm not a big fan of it, but maybe we should introduce a Discord/Enabled setting, to be consistent with settings from other sections?

TheUbMunster commented 1 year ago

It should not log these messages, in the default case where there is no Discord/Token configured in the settings.json, because it will confuse users:

https://github.com/Sanae6/SmoOnlineServer/blob/a5b834834c33d1fcb58d129b5c179eba1a3f643c/Server/DiscordBot.cs#L35

https://github.com/Sanae6/SmoOnlineServer/blob/a5b834834c33d1fcb58d129b5c179eba1a3f643c/Server/DiscordBot.cs#L64

I'm not a big fan of it, but maybe we should introduce a Discord/Enabled setting, to be consistent with settings from other sections?

should be good now. lmk