Closed KenthJohan closed 1 year ago
Thanks for the sugggestions! I'll give them a try ASAP :)
Hi @KenthJohan I hope you are doing well. I actually faced the same problem on the same setup. You may check my pull here and I will appreciate your opinion. https://github.com/SanderMertens/flecs/pull/582
Thanks!
Hey @wobes1 thanks. Isn't WSAStartup
required also?
Hello @KenthJohan are you referring to this? https://github.com/SanderMertens/flecs/pull/584 if so, yes I was missing it!
@SanderMertens @KenthJohan I believe this can be moved to "Done" since it is supported in https://github.com/SanderMertens/flecs/pull/582 and https://github.com/SanderMertens/flecs/pull/596
I am myself on MSYS64 with MingGW and latest flecs compiles flawlessly with these two.
Seems like this has been dealt with and can now be closed? @KenthJohan
_MSC_VER
is not defined onMinGW-w64 (MSYS2)
.__MINGW32__
andWIN32
is defined onMinGW-w64 (MSYS2)
. I don't know which one is better to use. MaybeWIN32
could be used for code that works both on__MINGW32__
and_MSC_VER
.Option 1
Option 2
Only these need to be changed to make it work for MinGW-w64 (MSYS2): https://github.com/SanderMertens/flecs/blob/3667290095250af280f9be2c1de1585afcdc73ca/src/addons/http.c#L37-L43 https://github.com/SanderMertens/flecs/blob/3667290095250af280f9be2c1de1585afcdc73ca/src/addons/http.c#L198-L200 https://github.com/SanderMertens/flecs/blob/3667290095250af280f9be2c1de1585afcdc73ca/src/addons/http.c#L644-L658 https://github.com/SanderMertens/flecs/blob/3667290095250af280f9be2c1de1585afcdc73ca/src/addons/http.c#L842-L846